For Ruby 2.7 tests use dedicated bundler version #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundler 2.4.22 is last version to support Ruby 2.7 and needs to be directly installed to prevent an error resolving the supported version. This requirement occurred with the release of bundler 2.5.0.
|
Merging to unblock pull request and release workflows. |
evgeni
reviewed
Dec 17, 2023
| @@ -15,6 +15,11 @@ def gemset(name = null) { | |||
|
|
|||
| def configureRVM(ruby, name = '', bundler_version = null) { | |||
| emptyGemset(ruby, name) | |||
|
|
|||
| if (ruby == '2.7') { | |||
| bundler_version = '2.4.22' | |||
There was a problem hiding this comment.
Should this be < 2.5 to allow 2.4.z patches?
There was a problem hiding this comment.
No idea. But since you are asking, I am assuming maybe yes.
There was a problem hiding this comment.
:)
I have no idea how high the chances of a 2.4.z is, but playing safe is always good :)
|
non-pipeline jobs are still failing. https://github.com/theforeman/jenkins-jobs/tree/master/theforeman.org/scripts/test needs to be updated. @pcreech is working on that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundler 2.4.22 is last version to support Ruby 2.7 and needs to be directly installed to prevent an error resolving the supported version. This requirement occurred with the release of bundler 2.5.0.